Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip sql tests when psql binary is not installed #16233

Merged
merged 2 commits into from
Jan 8, 2025
Merged

test: skip sql tests when psql binary is not installed #16233

merged 2 commits into from
Jan 8, 2025

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 8, 2025

What does this PR do?

These tests keep hanging when I run bun-debug test locally

@DonIsaac DonIsaac requested a review from Jarred-Sumner January 8, 2025 04:06
@robobun
Copy link

robobun commented Jan 8, 2025 •
edited
Loading

Updated 11:09 PM PT - Jan 7th, 2025

✅ @DonIsaac, your commit 93e54c6 has passed in #9204! 🎉

🧪   try this PR locally:

bunx bun-pr 16233

@DonIsaac Graphite App
Copy link
Contributor Author

DonIsaac commented Jan 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@DonIsaac DonIsaac mentioned this pull request Jan 8, 2025
Merged
2 tasks
@DonIsaac DonIsaac enabled auto-merge January 8, 2025 04:10
Jarred-Sumner
Jarred-Sumner requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests in tls-sql.test do not rely on psql

That test is missing a check for the environment variables

@paperclover paperclover disabled auto-merge January 8, 2025 21:59
@paperclover paperclover merged commit 833b718 into main Jan 8, 2025
68 checks passed
@paperclover paperclover deleted the don/test/cond-skip-psql-tests branch January 8, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paperclover paperclover paperclover approved these changes

@Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DonIsaac @robobun @Jarred-Sumner @paperclover