Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: format: switch to mlugg/setup-zig #12863

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

nektro
Copy link
Member

@nektro nektro commented Jul 27, 2024

found during working on #11492

goto-bus-stop/setup-zig is deprecated by the maintainer and no longer recommended. mlugg/setup-zig is now preferred and has multiple improvements.

this will additionally fix a warning thats raised in actions during runs

The following actions uses Node.js version which is deprecated and will be forced to run on node20: goto-bus-stop/setup-zig@c7b6cdd. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Copy link
Contributor

@nektro, your commit has failing tests :(

🐧🖥 1 failing tests Linux x64

  • test/js/node/async_hooks/AsyncLocalStorage.test.ts 1 failing

🪟💻 3 failing tests Windows x64 baseline

  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/js/bun/spawn/spawn.test.ts SIGKILL
  • test/js/node/child_process/child_process.test.ts 1 failing

🪟💻 2 failing tests Windows x64

  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/js/node/child_process/child_process.test.ts 1 failing

View logs

@Jarred-Sumner Jarred-Sumner merged commit 32d9bb3 into main Jul 27, 2024
49 of 54 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-58478 branch July 27, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants