-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(install): invalidate manifest cache on registry change #11606
Conversation
❌ @dylan-conway, your commit has failing tests :( 💪 1 failing tests Darwin AARCH64
🐧🖥 1 failing tests Linux x64
🪟💻 4 failing tests Windows x64 baseline
🪟💻 5 failing tests Windows x64
|
I think we should store the length also |
Like hash & length As another sanity check |
Let’s merge once tests run |
Thank you very much for this fix, looking forward to the next release to adopt bun as a package manager in our day 2 day development and CI/CD pipelines. It is also highly likely that the nature of all the related issues listed in #11582 (perhaps except the #5029) lies in the behaviour that was fixed in current mr. |
What does this PR do?
We need to make sure manifests in the cache are invalidated when the registry for the package changes. This pr bumps our serialized manifest version to 3, and writes the registry hash + length to end of the file.
fixes #11582
How did you verify your code works?
Added a test that installs the same package from two registries.