Use error handling callback in more places, emit 1015 when WSS TLS handshaking fails, micro-optimize ServerWebSocket, fix bug in util.inspect exceptions #10633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nErrorHandler` with `vm.onError`
Jarred-Sumner
requested review from
a team,
dylan-conway and
cirospaciari
and removed request for
a team
cirospaciari
approved these changes
Apr 29, 2024
| { | ||
| // LOG(Network, "WebSocket %p didReceiveErrorMessage()", this); | ||
| // queueTaskKeepingObjectAlive(*this, TaskSource::WebSocket, [this, reason = WTFMove(reason)] { | ||
| if (m_state == CLOSED) | ||
| return; | ||
| const bool wasConnecting = m_state == CONNECTING; |
There was a problem hiding this comment.
can't this be isConnectionError when the function is called instead?
didReceiveClose(CleanStatus::NotClean, 1006, message, m_state == CONNECTING);
There was a problem hiding this comment.
no, see the next line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
vm.runErrorHandlertovm.onErrorwhich calls the currently registered error handler instead of the global one. This may cause test failures, we will see.ServerWebSocketstruct size from 28 bytes -> 24 bytes, which should slightly improve performance (rounding to alignment it was probably 32 bytes before)[native code]because it was not correctly checking for exceptionsonConnectErrorand fixes a double free there. Fixes windows client websocket on error event causes crash #10619.WebSocketnow emits close code 1015 for TLS handshaking failure (cc @cirospaciari). Browsers do not do this. But on a server, this is useful information (image from the websocket spec).Along the way, noticed a bug with unhandled errors. We seem to continue executing in cases where we should not continue executing. I think it's simple to fix, but it is very much a breaking change until we do #5091
How did you verify your code works?
There are tests