New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better way to check if a directory exists #10235

Merged

Jarred-Sumner merged 4 commits into main from jarred/fix-directory-exists-at

Apr 13, 2024

Collaborator

Jarred-Sumner commented Apr 13, 2024

What does this PR do?

Hopefully fixes EEXIST issues on windows

How did you verify your code works?

We shall see

Jarred-Sumner added 3 commits

April 12, 2024 20:21


          Better way to check if a directory exists

c8d7f9c


          Update sys.zig

2255a3f


          Fix windows build

7d0e632

Contributor

github-actions bot commented Apr 13, 2024 •

edited

Loading

❌ @Jarred-Sumner 5 files with test failures on linux-x64-baseline:

test/integration/mysql2/mysql2.test.ts 6 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/node/http2/node-http2.test.js 1 failing
test/js/web/timers/setInterval.test.js 1 failing

View test output

^{#bd91ba26d3203838df0e112ae1c84c2c0e013156}

Contributor

github-actions bot commented Apr 13, 2024 •

edited

Loading

❌ @Jarred-Sumner 4 files with test failures on linux-x64:

test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/node/child_process/child-process-exec.test.ts 1 failing
test/js/node/http2/node-http2.test.js 1 failing

View test output

^{#bd91ba26d3203838df0e112ae1c84c2c0e013156}

Contributor

github-actions bot commented Apr 13, 2024 •

edited

Loading

❌ @Jarred-Sumner 1 files with test failures on bun-darwin-aarch64:

test/js/bun/http/serve.test.ts 2 failing

View test output

^{#bd91ba26d3203838df0e112ae1c84c2c0e013156}


          Add missing file

a6ce096

Contributor

github-actions bot commented Apr 13, 2024

❌ @Jarred-Sumner 10 files with test failures on bun-windows-x86_64-haswell

test\cli\install\bunx.test.ts 1 failing
test\cli\install\registry\bun-install-registry.test.ts 7 failing
test\integration\next-pages\test\dev-server-ssr-100.test.ts 1 failing
test\integration\next-pages\test\dev-server.test.ts 1 failing
test\integration\next-pages\test\next-build.test.ts 1 failing
test\js\bun\glob\scan.test.ts 6 failing
test\js\bun\shell\bunshell.test.ts 2 failing
test\js\node\child_process\child-process-exec.test.ts 1 failing
test\js\node\dns\node-dns.test.js SIGTERM
test\js\node\http2\node-http2.test.js 2 failing

View test output

^{#bd91ba26d3203838df0e112ae1c84c2c0e013156}

Contributor

github-actions bot commented Apr 13, 2024

❌ @Jarred-Sumner 4 files with test failures on bun-darwin-x64:

test/cli/install/bunx.test.ts SIGTERM
test/js/bun/spawn/spawn-kill-signal.test.ts 2 failing
test/js/bun/spawn/spawn.test.ts 1 failing
test/js/node/http2/node-http2.test.js 1 failing

View test output

^{#bd91ba26d3203838df0e112ae1c84c2c0e013156}

Jarred-Sumner merged commit 8d49a3e into main

27 of 32 checks passed

Jarred-Sumner deleted the jarred/fix-directory-exists-at branch

April 13, 2024 05:19

cirospaciari pushed a commit that referenced this pull request


          Better way to check if a directory exists (#10235)

* Better way to check if a directory exists

* Update sys.zig

* Fix windows build

* Add missing file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet