-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix create with github URL on windows #10231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ @gvilums 10 files with test failures on bun-windows-x86_64-haswell
|
❌ @gvilums 3 files with test failures on bun-darwin-aarch64:
|
❌ @gvilums 4 files with test failures on bun-darwin-x64:
|
thank you |
Jarred-Sumner
added a commit
that referenced
this pull request
Apr 13, 2024
This reverts commit 1820d08.
Jarred-Sumner
added a commit
that referenced
this pull request
Apr 13, 2024
cirospaciari
pushed a commit
that referenced
this pull request
Apr 14, 2024
* correctly ignore error on windows to match posix behavior * replace zig accessat with bun.sys.existsAt * fix posix build
cirospaciari
pushed a commit
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces some uses of zig stdlib
accessat
(which were running into unreachable) withbun.sys.existsAt
.Fixes #10183
How did you verify your code works?
Manual testing