Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create with github URL on windows #10231

Merged
merged 4 commits into from
Apr 13, 2024
Merged

fix create with github URL on windows #10231

merged 4 commits into from
Apr 13, 2024

Conversation

gvilums
Copy link
Contributor

@gvilums gvilums commented Apr 12, 2024

What does this PR do?

Replaces some uses of zig stdlib accessat (which were running into unreachable) with bun.sys.existsAt.
Fixes #10183

How did you verify your code works?

Manual testing

Copy link
Contributor

Copy link
Contributor

@Jarred-Sumner Jarred-Sumner merged commit 1820d08 into main Apr 13, 2024
27 of 31 checks passed
@Jarred-Sumner Jarred-Sumner deleted the georgijs/fix-create branch April 13, 2024 00:12
@Jarred-Sumner
Copy link
Collaborator

thank you

Jarred-Sumner added a commit that referenced this pull request Apr 13, 2024
Jarred-Sumner added a commit that referenced this pull request Apr 13, 2024
cirospaciari pushed a commit that referenced this pull request Apr 14, 2024
* correctly ignore error on windows to match posix behavior

* replace zig accessat with bun.sys.existsAt

* fix posix build
cirospaciari pushed a commit that referenced this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WINDOWS] bun create https://github.com/.... crash: 'reached unreachable code'
2 participants