Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AbortSignal & AbortController to latest from WebKit #10106

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Apr 9, 2024

What does this PR do?

Fixes #9977
Closes #10086

Thank you @lithdew for investigating and most of the fixes. This adds more of the changes we missed from WebKit into Bun like the ability to follow other signals

1st: after 2,000 requests
2nd: after 10,000 requests
3rd: after 50,000 requests

image

How did you verify your code works?

Fixes #9977
Closes #10086

Thank you @lithdew for investigating and most of the fixes. This adds more of the changes we missed from WebKit into Bun like the ability to follow other signals

Co-Authored-By: Kenta Iwasaki <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Copy link
Contributor

github-actions bot commented Apr 9, 2024

@Jarred-Sumner Jarred-Sumner merged commit df49a5a into main Apr 9, 2024
26 of 31 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/upgrade-abortsignal branch April 9, 2024 07:49
paperclover pushed a commit that referenced this pull request Apr 10, 2024
Fixes #9977
Closes #10086

Thank you @lithdew for investigating and most of the fixes. This adds more of the changes we missed from WebKit into Bun like the ability to follow other signals

Co-authored-by: Kenta Iwasaki <[email protected]>
@zackify
Copy link

zackify commented May 13, 2024

I'm seeing a leaking issue using remix with

import { renderToReadableStream } from "react-dom/server.bun";

let me know if i can help debug in some way. I'm trying to change a few things if I can isolate where it is.

Memory just grows like crazy as more requests come in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak running Next.js standalone bundle
2 participants