Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force non-zero exit code whenever bun install has any packages which failed to install #10041

Merged
merged 4 commits into from
Apr 7, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

There seem to be very subtle cases here bun install will fail to install a package for some reason and still end up with a non-zero exit code. It's nothing "obvious", it's not when a package fails to resolve or a package fails to download. It's more subtle. Like if the filesystem had a permissions issue and it's a dependency of a dependency, or something along those lines.

Let's see if any new test failures occur

How did you verify your code works?

Copy link
Contributor

github-actions bot commented Apr 7, 2024

Copy link
Contributor

github-actions bot commented Apr 7, 2024

@Jarred-Sumner 2 files with test failures on bun-darwin-aarch64:

View test output

#8f3c598722b8eff6ddb786f70a551cb0aded4791

Copy link
Contributor

github-actions bot commented Apr 7, 2024

Copy link
Contributor

github-actions bot commented Apr 7, 2024

@Jarred-Sumner Jarred-Sumner merged commit d615c11 into main Apr 7, 2024
20 of 21 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/non-zero branch April 7, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant