Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun install fails to handle registry URL ending with slash #2462

Closed
privatenumber opened this issue Mar 23, 2023 · 3 comments
Closed

bun install fails to handle registry URL ending with slash #2462

privatenumber opened this issue Mar 23, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@privatenumber
Copy link
Contributor

What version of Bun is running?

0.5.8

What platform is your computer?

Darwin 22.3.0 x86_64 i386

What steps can reproduce the bug?

bun i with a bunfig.toml configuring the registry url to end with a /:

[install]

registry = {
	url = "https://artifactory.REDACTED.net/artifactory/api/npm/"
}

What is the expected behavior?

For packages to install

What do you see instead?

Fails:

$ bun i
bun install v0.5.8 (1a25af5e)
  🔍 @datadog/pprof [8/44]
error: package "@datadog/pprof" not found artifactory.REDACTED.net/artifactory/api/npm//@datadog/pprof 404
  🔍 @datadog/pprof [8/44]
error: package "@protobufjs/eventemitter" not found artifactory.REDACTED.net/artifactory/api/npm//@protobufjs/eventemitter 404
  🔍 @datadog/pprof [8/44]
error: package "xmlbuilder" not found artifactory.REDACTED.net/artifactory/api/npm//xmlbuilder 404
  🔍 @permafrost-dev/pretty-format [12/44]
error: package "@permafrost-dev/pretty-format" not found artifactory.REDACTED.net/artifactory/api/npm//@permafrost-dev/pretty-format 404
  🔍 @devexpress/error-stack-parser [13/44]
error: package "@devexpress/error-stack-parser" not found artifactory.REDACTED.net/artifactory/api/npm//@devexpress/error-stack-parser 404
  🔍 @devexpress/error-stack-parser [13/44]

Additional information

No response

@privatenumber privatenumber added the bug Something isn't working label Mar 23, 2023
@Jarred-Sumner
Copy link
Collaborator

embarrassing

Jarred-Sumner added a commit that referenced this issue Mar 23, 2023
@privatenumber
Copy link
Contributor Author

Haha no! It's a very minor edge-case that's trivially fixable on the user-end. I just thought to file it since it should be handled for npm parity.

cirospaciari pushed a commit that referenced this issue Mar 31, 2023
@atombarel
Copy link

in bun 1.0.0 on linux I have 404 not found without / but it works with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants