yeah

oven-sh · Apr 17, 2024 · eb43700 · eb43700
1 parent b730add
commit eb43700
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 17 deletions.
diff --git a/.github/ISSUE_TEMPLATE/6-crash-report.yml b/.github/ISSUE_TEMPLATE/6-crash-report.yml
@@ -6,17 +6,15 @@ body:
     attributes:
       value: |
         Thank you for submitting a crash report. It helps make Bun better.
-        someone should write better text in here please
 
   - type: textarea
     id: remapped_trace
     attributes:
       label: Stack Trace
-      description: auto fill
     validations:
       required: true
 
   - type: textarea
     attributes:
-      label: fsdfasdfasdfa
+      label: Any extra info?
       description: If this is a reproducible bug, please provide a code snippet or list of steps that can reproduce it.
diff --git a/src/bun.js/module_loader.zig b/src/bun.js/module_loader.zig
@@ -2354,13 +2354,6 @@ pub const ModuleLoader = struct {
                     if (!Environment.isDebug) {
                         if (!is_allowed_to_use_internal_testing_apis)
                             return null;
-                        const is_outside_our_ci = brk: {
-                            const repo = jsc_vm.bundler.env.get("GITHUB_REPOSITORY") orelse break :brk true;
-                            break :brk !strings.endsWithComptime(repo, "/bun");
-                        };
-                        if (is_outside_our_ci) {
-                            return null;
-                        }
                     }
 
                     return jsSyntheticModule(.InternalForTesting, specifier);

diff --git a/src/crash_handler.zig b/src/crash_handler.zig
@@ -119,7 +119,7 @@ pub fn crashHandler(
                 //
                 // To make the release-mode behavior easier to demo, debug mode
                 // checks for this CLI flag.
-                const debug_trace = check_flag: {
+                const debug_trace = bun.Environment.isDebug or check_flag: {
                     for (bun.argv) |arg| {
                         if (bun.strings.eqlComptime(arg, "--debug-crash-handler-use-trace-string")) {
                             break :check_flag false;
@@ -1069,7 +1069,7 @@ fn handleErrorReturnTraceExtra(err: anyerror, maybe_trace: ?*std.builtin.StackTr
         //
         // To make the release-mode behavior easier to demo, debug mode
         // checks for this CLI flag.
-        const is_debug = check_flag: {
+        const is_debug = bun.Environment.isDebug or check_flag: {
             for (bun.argv) |arg| {
                 if (bun.strings.eqlComptime(arg, "--debug-crash-handler-use-trace-string")) {
                     break :check_flag false;
@@ -1107,11 +1107,10 @@ fn handleErrorReturnTraceExtra(err: anyerror, maybe_trace: ?*std.builtin.StackTr
             if (is_root) {
                 Output.prettyErrorln(
                     \\
-                    \\The trace for the above error has been captured as a URL,
-                    \\which will direct you to fill out a GitHub issue for Bun.
-                    \\This trace only includes functions in Bun, and contains none
-                    \\of your code data:
-                    \\<cyan>{}<r>
+                    \\To send a redacted crash report to Bun's team,
+                    \\please file a GitHub issue using the link below:
+                    \\
+                    \\ <cyan>{}<r>
                     \\
                 ,
                     .{ts},