Add a few more checks for isNumber()

oven-sh · Mar 8, 2023 · c6f0140 · c6f0140
1 parent e838f8b
commit c6f0140
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/src/bun.js/webcore/streams.zig b/src/bun.js/webcore/streams.zig
@@ -399,7 +399,8 @@ pub const StreamStart = union(Tag) {
         }
 
         if (value.get(globalThis, "chunkSize")) |chunkSize| {
-            return .{ .chunk_size = @intCast(Blob.SizeType, @truncate(i52, chunkSize.toInt64())) };
+            if (chunkSize.isNumber())
+                return .{ .chunk_size = @intCast(Blob.SizeType, @truncate(i52, chunkSize.toInt64())) };
         }
 
         return .{ .empty = {} };
@@ -432,8 +433,10 @@ pub const StreamStart = union(Tag) {
                 }
 
                 if (value.get(globalThis, "highWaterMark")) |chunkSize| {
-                    empty = false;
-                    chunk_size = @intCast(JSC.WebCore.Blob.SizeType, @max(0, @truncate(i51, chunkSize.toInt64())));
+                    if (chunkSize.isNumber()) {
+                        empty = false;
+                        chunk_size = @intCast(JSC.WebCore.Blob.SizeType, @max(0, @truncate(i51, chunkSize.toInt64())));
+                    }
                 }
 
                 if (!empty) {
@@ -450,7 +453,8 @@ pub const StreamStart = union(Tag) {
                 var chunk_size: JSC.WebCore.Blob.SizeType = 0;
 
                 if (value.get(globalThis, "highWaterMark")) |chunkSize| {
-                    chunk_size = @intCast(JSC.WebCore.Blob.SizeType, @max(0, @truncate(i51, chunkSize.toInt64())));
+                    if (chunkSize.isNumber())
+                        chunk_size = @intCast(JSC.WebCore.Blob.SizeType, @max(0, @truncate(i51, chunkSize.toInt64())));
                 }
 
                 if (value.get(globalThis, "path")) |path| {
@@ -485,8 +489,10 @@ pub const StreamStart = union(Tag) {
                 var chunk_size: JSC.WebCore.Blob.SizeType = 2048;
 
                 if (value.get(globalThis, "highWaterMark")) |chunkSize| {
-                    empty = false;
-                    chunk_size = @intCast(JSC.WebCore.Blob.SizeType, @max(256, @truncate(i51, chunkSize.toInt64())));
+                    if (chunkSize.isNumber()) {
+                        empty = false;
+                        chunk_size = @intCast(JSC.WebCore.Blob.SizeType, @max(256, @truncate(i51, chunkSize.toInt64())));
+                    }
                 }
 
                 if (!empty) {