Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

framac: fixes workflow using github-ready image #4

Merged
merged 8 commits into from
Aug 1, 2024
Merged

framac: fixes workflow using github-ready image #4

merged 8 commits into from
Aug 1, 2024

Conversation

pthierry-ledger
Copy link
Member

@pthierry-ledger pthierry-ledger commented Jul 31, 2024 •
edited
Loading

  • Using pthierry38/framac-runner:29 image, based on official frama-c/framac:29 Debian image
  • Add some related fix associated to the usage of a Debian-based bare image (and not an ubuntu one as Github would like)
  • Using dynamic venv for python directly at job level
  • Fixed a bug in the autotest meson.build file that used the parseelf.py script as a program, which lead to failure when using venv. Using the meson python module find_installation() instead for calling
  • increasing the job timeout to 60 minutes (enough by now)
  • still a failure in the wp-rcc test, set as expected_fail, opening an issue instead

Closes #5

@pthierry-ledger pthierry-ledger added bug Something isn't working ci-cd About ci-cd related features and enhancement labels Jul 31, 2024
@pthierry-ledger pthierry-ledger force-pushed the ci-fix-framac-image branch 7 times, most recently from a7a7018 to a0687fb Compare July 31, 2024 15:56
fvalette-ledger
fvalette-ledger reviewed Aug 1, 2024
View reviewed changes
autotest/meson.build
Comment on lines +75 to +76
py3,
parseelf.full_path(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?
Meson must handle that in a portable way as parseelf is found w/ find_program.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kept by now, to be checked against windows. If useless to be removed. Opening an issue

@fvalette-ledger fvalette-ledger self-requested a review August 1, 2024 08:23
@pthierry-ledger pthierry-ledger merged commit b43261a into main Aug 1, 2024
43 checks passed
@pthierry-ledger pthierry-ledger deleted the ci-fix-framac-image branch September 11, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvalette-ledger fvalette-ledger fvalette-ledger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ci-cd About ci-cd related features and enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

frama-c: reactivate CI workflow
2 participants
@pthierry-ledger @fvalette-ledger