-
Notifications
You must be signed in to change notification settings - Fork 192
Conversation
server.register(HapiAuthBasic, function (err) { | ||
|
||
if (err) { | ||
return next(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your indentation is not 4 spaces consistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hussainanjar . I ended up copying the .eslintrc and .eslintignore from lab and putting it in the root directory of this project. I then turned on indentationn to match the style we are trying to follow:
"indent": [2, 4]
http://eslint.org/docs/rules/indent.html
Is it common to do this with Lab? Lab has a default for both of these files, but to add a new rule or change rules, you just copy it and make modifications? Should these be committed to the project?
I opened this pull request over at lab to hopefully catch things like this in the future. |
@tielur 👍 |
Lab was updated, so you should now get a warning for indentation. Something like this:
|
Nice! |
|
||
var isValid = password === user.password; | ||
|
||
return callback(null, isValid, { username: user.username}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space before }
closes #118