-
-
Notifications
You must be signed in to change notification settings - Fork 588
feat: add a custom scrollbar theme for the scrollable wrapper #320
Conversation
Hey @PhilReinking – this is an issue when you're using a mouse, or have the settings to "always show scrollbars", honestly it baffles me that chrome doesn't use a dark style by default still. Unfortunately adding this css does mean a regression in the case of using a trackpad, which currently looks like this: …but with the css above gains a permanent scrollbar. If you're aware of a css combo that would achieve both that would be very mergable. |
Hey Tom, you're right. These changes would always enable the scrollbar regardless of the device. I was not aware of that. I just made a quick check, and I think it would affect:
I use my MacBook in combination with a mouse, and therefore the scrollbars are not hidden. Without knowing much about the most popular devices used to access Outline, it may be possible that most users are distracted by this white scrollbar in dark mode. So I just want to mention two solutions I see from here:
Let me know if one of this solutions would be the way to go or maybe someone can come up with something better :) |
also added the CSS needed for firefox custom scrollbars
Great, confirmed in FireFox. Would you mind adding values to |
Done 😊 |
This PR improves upon PR #319
Native Scrollbars are at least on macOS "light-themed" even when the system is in dark mode.
To make the editor look more consistent in dark mode, I added custom scrollbar CSS, which turns the scrollbar for the
.scrollable
wrapper dark.Please note: this works only for webkit based browsers.
Please view to following screenshots:
Before:

After:
