This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix: Cannot use multiple underscore characters within inline code mark #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommoor
commented
Sep 30, 2020
| @@ -30,7 +30,7 @@ export default class Code extends Mark { | |||
|
|
|||
| get schema() { | |||
| return { | |||
| excludes: "strong em link mark strikethrough", | |||
| excludes: "_", | |||
There was a problem hiding this comment.
Note: This is something of a coincidence – the _ character in a prosemirror node spec means "any mark", it does not mean a literal underscore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the inline markdown nature of the editor we can't stop underlines from parsing entirely, but they can and should be ignored within an inline code mark.
closes #296