Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store allowlist rejections #57

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Store allowlist rejections #57

merged 2 commits into from
Dec 24, 2024

Conversation

Brayden
Copy link
Member

@Brayden Brayden commented Dec 22, 2024

Purpose

These updates to the Query Allowlist feature does three primary tasks:

  1. A better deep comparison of the query so queries, for example, with LIMIT 5 and LIMIT 6 are considered different. Previously the ending value was ignored and treated as a ? variable value.
  2. When a rejected query fails out of the verification check, log that query to our internal data source. This will help allow us to see what queries are coming through and allow us to quickly and easily mark it as approved if necessary.
  3. Stores the source in approved queries so you can specify which source (internal/external) should have the rule applied to it.

Tasks

  • Better query value checking for comparisons
  • Store rejected queries in the internal data source
  • Store source for approved queries

Verify

Before

After

@Brayden Brayden marked this pull request as ready for review December 24, 2024 14:57
@Brayden Brayden self-assigned this Dec 24, 2024
@Brayden Brayden added the enhancement New feature or request label Dec 24, 2024
@Brayden Brayden merged commit f45bcdf into main Dec 24, 2024
@Brayden Brayden deleted the bwilmoth/allowlist-rejections branch December 24, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant