Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS Preflight #43

Merged
merged 2 commits into from
Dec 1, 2024
Merged

CORS Preflight #43

merged 2 commits into from
Dec 1, 2024

Conversation

Brayden
Copy link
Member

@Brayden Brayden commented Dec 1, 2024

Purpose

By default CORS requests are blocked when trying to HTTP access a StarbaseDB instance from localhost or other domains. This pull request aims to make it so now by default all requests are allowed to access the instance and users can configure more narrow restrictions.

Tasks

  • Allow all origins by default
  • Remove unused utils function
  • Handle preflight check

Verify

Before

After

@Brayden Brayden self-assigned this Dec 1, 2024
@Brayden Brayden added the enhancement New feature or request label Dec 1, 2024
@Brayden Brayden merged commit ec2236e into main Dec 1, 2024
@Brayden Brayden deleted the bwilmoth/cors branch December 1, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant