fix: Add sale time validation in FixedPriceAllowedMintersStrategy #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Add sale time validation in FixedPriceAllowedMintersStrategy
Description
Added validation in the
setSale
function to ensure thatsaleStart
is always less thansaleEnd
. Previously, it was possible to create a sale with invalid time window where end time was before start time, which could lead to tokens being unmintable.Changes made:
setSale
functionInvalidSaleTime
error to the interfaceMotivation and Context
This fixes a potential issue where tokens could become unmintable if a sale was configured with
saleEnd
beforesaleStart
. The validation ensures that all sales have a valid time window.Does this change the ABI/API?
Added new error
InvalidSaleTime
to the interface. This is a backwards compatible change as it only adds a new error case.What tests did you add/modify to account for these changes
Added test cases to verify:
Types of changes
Checklist:
Reviewer Checklist: