Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add governance delay #124

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Conversation

neokry
Copy link
Collaborator

@neokry neokry commented Dec 13, 2023

Fixes an issue where a DAO with no veto using minters like MerkleReserveMinter could be captured in the following scenario:

  1. DAO is deployed and sets up allowlist using MerkleResserveMinter
  2. User mints tokens and creates a malicous proposal in the same block the allowlist is set
  3. Malicious proposer is the only one that can vote effectively capturing the DAO

Adding a delay to governance will negate this type of capture as malicious proposers will be unable to propose until the delay is expired or all reserved tokens are claimed. Founders can set this delay before setting the MerkleReserveMinter as an allowed minter and the L2MigrationDeployer contract has been updated to set a delay for migrating DAOs.

This does not fix a related issue where quorum can be manipulated by claimants with large amounts of tokens to claim. We consider that partially mitigated as more voters will have claimed their tokens and can effectively vote down the bad proposal but we will also inform DAOs of the risks around using allowlists where users have a high number of claims available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant