Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display deposit period in ProposalDetail #358

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Display deposit period in ProposalDetail #358

merged 2 commits into from
Aug 2, 2022

Conversation

hochiw
Copy link
Contributor

@hochiw hochiw commented Aug 2, 2022 •
edited by zube bot
Loading

  • Added remainingDepositDuration to proposal detail api and model
  • Extracted the date range component and handled displaying the durations based on the proposal status
Deposit Voting
Screenshot 2022-08-02 at 11 51 13 AM Screenshot 2022-08-02 at 11 51 34 AM

refs #351

@hochiw hochiw requested a review from elise-ng August 2, 2022 03:54
@hochiw hochiw merged commit 0197737 into oursky:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elise-ng elise-ng elise-ng approved these changes

Assignees

@elise-ng elise-ng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hochiw @elise-ng