-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup] Remove unused from_kwargs config function #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noxan
changed the title
remove unused from_kwargs config function
[cleanup] remove unused from_kwargs config function
Nov 24, 2022
noxan
changed the title
[cleanup] remove unused from_kwargs config function
[cleanup] Remove unused from_kwargs config function
Nov 24, 2022
Model Benchmark
|
Codecov Report
@@ Coverage Diff @@
## main #988 +/- ##
==========================================
+ Coverage 89.19% 89.20% +0.01%
==========================================
Files 18 18
Lines 4450 4447 -3
==========================================
- Hits 3969 3967 -2
+ Misses 481 480 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
karl-richter
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
karl-richter
added
status: ready
PR is ready to be merged
and removed
status: needs review
PR needs to be reviewed by Reviewer(s)
labels
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.