Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lightning] refactored Trainer args #959

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

karl-richter
Copy link
Collaborator

Added the minimal mode to the Lightning Trainer (speedup up to 2.5x).
Speedup the training when using the progress bar up to 2x.

@karl-richter karl-richter self-assigned this Nov 15, 2022
@karl-richter karl-richter added type:bug Something isn't working status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 15, 2022
@github-actions
Copy link

github-actions bot commented Nov 15, 2022

1b04374

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
PeytonManning MAE_val 0.64636 0.64636 -0.0%
PeytonManning RMSE_val 0.79276 0.79276 -0.0%
PeytonManning Loss_val 0.01494 0.01494 -0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 -0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
YosemiteTemps MAE_val 1.72949 1.72948 -0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 -0.0%
YosemiteTemps Loss_val 0.00096 0.00096 -0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 -0.0%
YosemiteTemps RMSE 2.16631 2.16631 -0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@Kevin-Chen0
Copy link
Collaborator

Can you take a look at what is causing the error for tests / build (windows-latest, 3.7) (pull_request)?

@Kevin-Chen0 Kevin-Chen0 added status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #959 (d19ab59) into main (686335a) will increase coverage by 0.02%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
+ Coverage   87.38%   87.41%   +0.02%     
==========================================
  Files          17       17              
  Lines        4462     4464       +2     
==========================================
+ Hits         3899     3902       +3     
+ Misses        563      562       -1     
Impacted Files Coverage Δ
neuralprophet/forecaster.py 87.93% <ø> (-0.02%) ⬇️
neuralprophet/utils.py 83.33% <88.88%> (+0.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@karl-richter karl-richter added this to the Release 0.5.0 milestone Nov 16, 2022
@karl-richter karl-richter added status: needs review PR needs to be reviewed by Reviewer(s) and removed status: needs update PR has outstanding comment(s) or PR test(s) that need to be resolved labels Nov 16, 2022
Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karl-richter karl-richter merged commit 1b04374 into main Nov 16, 2022
@karl-richter karl-richter deleted the fix/lightning_speedup branch November 16, 2022 18:27
@Kevin-Chen0 Kevin-Chen0 added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants