-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels in CONTRIBUTING.md #946
Conversation
Model BenchmarkShow benchmark results
Model TrainingPeytonManningYosemiteTempsAirPassengers |
Codecov Report
@@ Coverage Diff @@
## main #946 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 17 17
Lines 4433 4433
=======================================
Hits 3887 3887
Misses 546 546 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I like the ideas of labels a lot. Yet I would strongly advocate for a bot to keep our labels on PRs updated. we just saw that in the last core meeting, github has already status indicators built in (e.g. needs review, approved, needs changes) and we should follow those for our labels. Otherwise we have mismatched information and rather cause confusion, my 2 cents. Happy to have a chat on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose to merge the current state as we already use the labels and have anyone propose and discuss changes as follow up pull requests.
No description provided.