Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve github action speed for docs test #936

Merged
merged 8 commits into from
Nov 22, 2022

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Nov 7, 2022

@noxan noxan changed the title [dev-ops] Improve docs github action speed [dev-ops] Improve docs test github action speed Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

40c9a90

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
PeytonManning MAE_val 0.64636 0.64636 -0.0%
PeytonManning RMSE_val 0.79276 0.79276 -0.0%
PeytonManning Loss_val 0.01494 0.01494 -0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 -0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
YosemiteTemps MAE_val 1.72949 1.72948 -0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 -0.0%
YosemiteTemps Loss_val 0.00096 0.00096 -0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 -0.0%
YosemiteTemps RMSE 2.16631 2.16631 -0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@noxan noxan changed the title [dev-ops] Improve docs test github action speed Improve github action speed for docs test Nov 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Merging #936 (40c9a90) into main (cce32c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files          17       17           
  Lines        4464     4464           
=======================================
  Hits         3902     3902           
  Misses        562      562           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noxan noxan marked this pull request as ready for review November 8, 2022 19:25
@noxan noxan self-assigned this Nov 8, 2022
@karl-richter
Copy link
Collaborator

Really good idea! Can we also add this to the other tests that use the pip requirements file? eg. the metrics.yml test.

@noxan
Copy link
Collaborator Author

noxan commented Nov 16, 2022

@karl-richter yes, we could, I'd also support the idea. happy to follow up on this, might make sense to fix our dependency versions along that task.

@Kevin-Chen0
Copy link
Collaborator

Is this for version 0.5.0?

@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 17, 2022
Copy link
Collaborator

@karl-richter karl-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karl-richter karl-richter added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 17, 2022
@Kevin-Chen0 Kevin-Chen0 merged commit f230080 into main Nov 22, 2022
@Kevin-Chen0 Kevin-Chen0 deleted the feature/improve-docs-ci-speed branch November 22, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants