Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] fixed ruff warnings #1408

Merged
merged 1 commit into from
Aug 24, 2023
Merged

[bug] fixed ruff warnings #1408

merged 1 commit into from
Aug 24, 2023

Conversation

leoniewgnr
Copy link
Collaborator

🔬 Background

ruf warnings because type instead of isinstance was used

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.34899 1.34899 0.0%
YosemiteTemps RMSE_val 2.00817 2.00817 0.0%
YosemiteTemps Loss_val 0.00078 0.00078 0.0%
YosemiteTemps MAE 1.32133 1.32133 0.0%
YosemiteTemps RMSE 2.13713 2.13713 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 73.8058 71.1 -3.67%
PeytonManning MAE_val 0.58162 0.58162 0.0%
PeytonManning RMSE_val 0.72218 0.72218 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 15.7823 14.78 -6.35% 🎉
AirPassengers MAE_val 13.0627 13.0627 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88153 9.88153 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 6.69458 6.33 -5.45% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1408 (7dae671) into main (596c3ee) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1408   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          38       38           
  Lines        5067     5067           
=======================================
  Hits         4554     4554           
  Misses        513      513           
Files Changed Coverage Δ
neuralprophet/df_utils.py 94.65% <100.00%> (ø)
neuralprophet/plot_utils.py 88.01% <100.00%> (ø)

Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoniewgnr leoniewgnr merged commit fcc13e9 into main Aug 24, 2023
@leoniewgnr leoniewgnr deleted the fix-ruff-warnings branch August 24, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants