Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] fix sum of components #1349

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[minor] fix sum of components #1349

merged 1 commit into from
Jun 14, 2023

Conversation

leoniewgnr
Copy link
Collaborator

@leoniewgnr leoniewgnr commented Jun 12, 2023

🔬 Background

see #1348

🔮 Key changes

changed = + to +=

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 5.20161 5.3 1.89%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 12.2588 12.5 1.97%
YosemiteTemps MAE_val 1.3442 1.3442 0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 0.0%
YosemiteTemps Loss_val 0.00077 0.00077 0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 58.8627 58.67 -0.33%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1349 (3c6c6f8) into main (8465b40) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1349   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          38       38           
  Lines        5103     5103           
=======================================
  Hits         4587     4587           
  Misses        516      516           
Impacted Files Coverage Δ
neuralprophet/time_net.py 91.07% <100.00%> (ø)

@leoniewgnr leoniewgnr requested a review from ourownstory June 13, 2023 16:28
@ourownstory ourownstory self-assigned this Jun 14, 2023
Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ourownstory ourownstory marked this pull request as ready for review June 14, 2023 04:21
@ourownstory ourownstory merged commit 9ea11d7 into main Jun 14, 2023
@ourownstory ourownstory deleted the fix-sum-components branch June 14, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants