-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[devops] Add ruff github action #1324
Conversation
Model Benchmark
|
Codecov Report
@@ Coverage Diff @@
## main #1324 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 38 38
Lines 5104 5104
=======================================
Hits 4586 4586
Misses 518 518 |
@noxan why does the linters /ruff test fail? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great upgrade, thank you Richard!
What do you suggest to do about it's list of errors? Should we address all or should we relax what constitutes an error?
@noxan Might it make sense to also add this to the pre-commit or pre-push hook? |
We should migrate our pre-commit hooks to https://pre-commit.com/ - great idea to include it there too. We might be able to drop flake8 and isort over time (to be replaced by ruff). Regarding the warnings: So far we excluded the |
🔬 Background