Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devops] Add ruff github action #1324

Merged
merged 2 commits into from
May 16, 2023
Merged

[devops] Add ruff github action #1324

merged 2 commits into from
May 16, 2023

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented May 10, 2023

🔬 Background

@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label May 10, 2023
@github-actions
Copy link

github-actions bot commented May 10, 2023

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.58159 0.58159 -0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 -0.0%
PeytonManning MAE 0.41671 0.41671 -0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 16.2544 12.92 -20.51% 🎉
YosemiteTemps MAE_val 1.3442 1.3442 -0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 -0.0%
YosemiteTemps Loss_val 0.00077 0.00077 -0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 -0.0%
YosemiteTemps Loss 0.00064 0.00064 -0.0%
YosemiteTemps time 75.5026 60.49 -19.88% 🎉
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9452 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 6.71087 5.47 -18.49% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #1324 (85db287) into main (e924677) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1324   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          38       38           
  Lines        5104     5104           
=======================================
  Hits         4586     4586           
  Misses        518      518           

@leoniewgnr
Copy link
Collaborator

@noxan why does the linters /ruff test fail?

Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great upgrade, thank you Richard!

What do you suggest to do about it's list of errors? Should we address all or should we relax what constitutes an error?

@ourownstory
Copy link
Owner

@noxan Might it make sense to also add this to the pre-commit or pre-push hook?

@noxan
Copy link
Collaborator Author

noxan commented May 13, 2023

We should migrate our pre-commit hooks to https://pre-commit.com/ - great idea to include it there too.

We might be able to drop flake8 and isort over time (to be replaced by ruff).

Regarding the warnings: So far we excluded the tests folder. Ruff also has an autofix feature, I've pushed things to a branch here: https://github.com/ourownstory/neural_prophet/compare/ruff-fixes?expand=1
Most other warnings are about line lengths.

@noxan noxan mentioned this pull request May 13, 2023
@noxan noxan merged commit 2cf8c04 into main May 16, 2023
@noxan noxan deleted the ruff branch May 16, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants