-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] Update dependencies to latest versions #1305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model Benchmark
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1305 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 38 38
Lines 5142 5142
=======================================
Hits 4619 4619
Misses 523 523 |
noxan
force-pushed
the
update-dependencies-v2
branch
from
April 26, 2023 07:10
5dfe49e
to
febdc51
Compare
noxan
force-pushed
the
update-dependencies-v2
branch
from
April 26, 2023 07:16
febdc51
to
a853023
Compare
leoniewgnr
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
leoniewgnr
added
status: ready
PR is ready to be merged
and removed
status: needs review
PR needs to be reviewed by Reviewer(s)
labels
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Future work
numpy 1.24.3
fails due to: FAILED tests/test_plotting.py::test_plot_trend[matplotlib] - ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (2,) + inhomogeneous part. (see failed github action).torch
andpytorch-lightning
are tracked in Transition to Pytorch 2.0 #1229flake8
would requirepython>=3.8.1
somehowholidays
returns different number of holidays from time to timeplotly-resampler
andpandas
depend on another (requiresplotly-resampler=0.9.0rc0
forpandas=2.0.1
) and fail (see github action logs)Todos