Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Raise ValueError when df contains not enough rows #1300

Merged
merged 3 commits into from
Apr 22, 2023

Conversation

judussoari
Copy link
Collaborator

🔬 Background

When using auto-regression with a dataset that is smaller than n_forecasts + n_lags the fit method throws an IndexError. This hides the real problem, which is that the user is trying to train a model on not enough data.

🔮 Key changes

  • raise an error which tells the user to lower the number of forecasts and/or lags, or asks for a larger dataset

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@judussoari judussoari added type:bug Something isn't working status: needs review PR needs to be reviewed by Reviewer(s) priority:P1 High priority labels Apr 21, 2023
@judussoari judussoari added this to the Release 0.6.0 milestone Apr 21, 2023
@judussoari judussoari self-assigned this Apr 21, 2023
@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 5.29164 4.82 -8.91% 🎉
YosemiteTemps MAE_val 1.3442 1.3442 0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 0.0%
YosemiteTemps Loss_val 0.00077 0.00077 0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 65.9804 60.19 -8.78% 🎉
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 12.193 11.77 -3.47%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Merging #1300 (0a6f441) into main (b9ffa72) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1300   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          38       38           
  Lines        5134     5136    +2     
=======================================
+ Hits         4614     4616    +2     
  Misses        520      520           
Impacted Files Coverage Δ
neuralprophet/data/process.py 92.56% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@judussoari judussoari requested a review from leoniewgnr April 22, 2023 01:50
Copy link
Collaborator

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoniewgnr leoniewgnr merged commit d26b9f6 into main Apr 22, 2023
@leoniewgnr leoniewgnr deleted the fix/unclear_error branch April 22, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:P1 High priority status: needs review PR needs to be reviewed by Reviewer(s) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error when doing auto-regression with too small dataset
3 participants