Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Encapsulate _prepare_dataframe_to_predict #1290

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

LeonieFreisinger
Copy link
Collaborator

🔬 Background

Related to #1133
This PR is part of a series of PRs belonging to step 2 of restructuring the forecaster.py. Step 1 was to move identified functions out of the forecaster.py into dedicated files. Step 2 is to encapsulate the input arguments of the moved functions. Step2 will be implemented step-by-step within multiple PRs

🔮 Key changes

  • Encapsulate _prepare_dataframe_to_predict including docstring and typing. Model still needs to for passing on to _check_dataframe

📋 Review Checklist

  • I have performed a self-review of my own code.
  • N.A. [ ] I have commented my code, added docstrings and data types to function definitions.
  • N.A. [ ] I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@github-actions
Copy link

github-actions bot commented Apr 20, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 13.0626 13.0626 -0.0%
AirPassengers RMSE_val 15.9453 15.9452 -0.0%
AirPassengers Loss_val 0.00131 0.00131 -0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 6.70212 7.95 18.62%
YosemiteTemps MAE_val 1.3442 1.3442 -0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 -0.0%
YosemiteTemps Loss_val 0.00077 0.00077 -0.0%
YosemiteTemps MAE 1.3192 1.3192 -0.0%
YosemiteTemps RMSE 2.13518 2.13518 -0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 82.4342 98.93 20.01%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 -0.0%
PeytonManning Loss 0.00612 0.00612 -0.0%
PeytonManning time 15.8784 19.14 20.54%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@LeonieFreisinger LeonieFreisinger self-assigned this Apr 20, 2023
@LeonieFreisinger LeonieFreisinger added the status: needs review PR needs to be reviewed by Reviewer(s) label Apr 20, 2023
@LeonieFreisinger LeonieFreisinger added this to the Release 0.6.0 milestone Apr 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #1290 (01a0e17) into main (05b093c) will not change coverage.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1290   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          38       38           
  Lines        5128     5128           
=======================================
  Hits         4608     4608           
  Misses        520      520           
Impacted Files Coverage Δ
neuralprophet/data/process.py 92.46% <75.00%> (ø)
neuralprophet/forecaster.py 87.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LeonieFreisinger LeonieFreisinger requested a review from noxan April 20, 2023 21:40
Copy link
Collaborator

@noxan noxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeonieFreisinger LeonieFreisinger merged commit 5e8fa94 into main Apr 20, 2023
@LeonieFreisinger LeonieFreisinger deleted the lighten_forecaster_7 branch April 20, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants