Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Unregister plotly resampler directly after usage #1277

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

LeonieFreisinger
Copy link
Collaborator

🔬 Background

The plotly_resampler has not been unregistered after usage. That causes an error when plotting a go.Figure while having neuralprophet imported.

🔮 Key changes

  • unregister plotly_resampler after every function call of a plotting function before it returns the fig.
  • info: plotly_resampler functionality s not affected by it.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • N.A. [ ] I have commented my code, added docstrings and data types to function definitions.
  • N.A. [ ] I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@LeonieFreisinger LeonieFreisinger requested a review from noxan April 18, 2023 01:50
@LeonieFreisinger LeonieFreisinger self-assigned this Apr 18, 2023
@LeonieFreisinger LeonieFreisinger added the status: needs review PR needs to be reviewed by Reviewer(s) label Apr 18, 2023
@LeonieFreisinger LeonieFreisinger added this to the Release 0.6.0 milestone Apr 18, 2023
@github-actions
Copy link

github-actions bot commented Apr 18, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 4.00842 4.37 9.02%
YosemiteTemps MAE_val 1.71298 1.71298 0.0%
YosemiteTemps RMSE_val 2.2607 2.2607 0.0%
YosemiteTemps Loss_val 0.00095 0.00095 0.0%
YosemiteTemps MAE 1.45187 1.45187 0.0%
YosemiteTemps RMSE 2.16721 2.16721 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 91.2258 101.5 11.26%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 11.5787 12.38 6.92% ⚠️
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #1277 (2f7f860) into main (8b00060) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2f7f860 differs from pull request most recent head c93cfa5. Consider uploading reports for the commit c93cfa5 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1277   +/-   ##
=======================================
  Coverage   89.87%   89.88%           
=======================================
  Files          38       38           
  Lines        5068     5073    +5     
=======================================
+ Hits         4555     4560    +5     
  Misses        513      513           
Impacted Files Coverage Δ
neuralprophet/plot_forecast_plotly.py 87.10% <100.00%> (+0.20%) ⬆️
neuralprophet/plot_model_parameters_plotly.py 94.95% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@noxan noxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noxan noxan changed the title [fix] unregister plotly resampler directly after usage [fix] Unregister plotly resampler directly after usage Apr 18, 2023
@noxan noxan merged commit 19f6de4 into main Apr 18, 2023
@noxan noxan deleted the fix_unregister_resampler branch April 18, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants