Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔬 Background
Some warnings could be fixed, fixes #1159
🔮 Key changes
Fixed warnings
Not addressed and reason
warnings.warn("Could not import lttbc; will use a (slower) python alternative.")
--> will be removed in the near future, see Windows: Could not import lttbc predict-idlab/plotly-resampler#180
--> is already fixed in torch 2.0, see here for the commit, that fixes it: fix DeprecationWarning pytorch/pytorch#95545 (merged on Feb 27)
pkg_resources.declare_namespace('pytorch_lightning')
.Implementing implicit namespace packages (as specified in PEP 420) is preferred to
pkg_resources.declare_namespace
. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packagesimport("pkg_resources").declare_namespace(name)
--> Lightning knows about the warning and are on it, see DeprecationWarning: pkg_resources is deprecated as an API Lightning-AI/pytorch-lightning#16756
📋 Review Checklist