Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Address warnings #1276

Merged
merged 1 commit into from
Apr 18, 2023
Merged

[minor] Address warnings #1276

merged 1 commit into from
Apr 18, 2023

Conversation

leoniewgnr
Copy link
Collaborator

🔬 Background

Some warnings could be fixed, fixes #1159

🔮 Key changes

Fixed warnings

  • test_integration.py: neuralprophet/data/process.py:126: DeprecationWarning: The default dtype for empty Series will be 'object' instead of 'float64' in a future version. Specify a dtype explicitly to silence this warning.

Not addressed and reason

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@leoniewgnr leoniewgnr self-assigned this Apr 17, 2023
@leoniewgnr leoniewgnr added the status: needs review PR needs to be reviewed by Reviewer(s) label Apr 17, 2023
@leoniewgnr leoniewgnr requested a review from noxan April 17, 2023 23:37
@leoniewgnr leoniewgnr changed the title [task] adress warnings [minor] adress warnings Apr 17, 2023
@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 4.10218 4.06 -1.03%
YosemiteTemps MAE_val 1.71298 1.71298 0.0%
YosemiteTemps RMSE_val 2.2607 2.2607 0.0%
YosemiteTemps Loss_val 0.00095 0.00095 0.0%
YosemiteTemps MAE 1.45187 1.45187 0.0%
YosemiteTemps RMSE 2.16721 2.16721 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 93.5185 91.36 -2.31%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 11.683 11.53 -1.31%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@noxan noxan changed the title [minor] adress warnings [minor] Address warnings Apr 18, 2023
Copy link
Collaborator

@noxan noxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noxan noxan marked this pull request as ready for review April 18, 2023 02:00
@noxan noxan merged commit 3122da9 into main Apr 18, 2023
@noxan noxan deleted the adress-all-warnings branch April 18, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adress all warnings
2 participants