-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] Allow lagged regressors with only unique values for global modeling #1256
Conversation
*in case of global normalization *As long as this is not the case for all time series in the dataset
Model Benchmark
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1256 +/- ##
==========================================
- Coverage 89.63% 89.62% -0.01%
==========================================
Files 35 35
Lines 4938 4953 +15
==========================================
+ Hits 4426 4439 +13
- Misses 512 514 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* No regressor drop if df check is called by make_future_dataframe() * Test Integration
* No regressor drop if df check is called by make_future_dataframe() * Test Integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Would it be good to write a test because the code covarage is below the target? |
# Conflicts: # neuralprophet/forecaster.py
🔬 Background
Fixes #608
Fixes #1153
Picks up from #1146
Currently, NeuralProphet does not allow a lagged regressor to only contain unique values. When global modeling, however, there are reasonable cases in which some IDs may have only unique values, while others don't.
🔮 Key changes
Instead of throwing an Error immediately, we first check whether we have unique values cross all IDs. If not, we give a warning.
📋 Review Checklist