Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Adjust seasonality reg to modularized code #1203

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Conversation

judussoari
Copy link
Collaborator

🔬 Background

Bug because self.season_params does not exist anymore with the newly modularized seasonality.

🔮 Key changes

Change to self.seasonality.season_params

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@judussoari judussoari self-assigned this Mar 7, 2023
@judussoari judussoari marked this pull request as ready for review March 7, 2023 23:27
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.71298 1.71298 0.0%
YosemiteTemps RMSE_val 2.2607 2.2607 0.0%
YosemiteTemps Loss_val 0.00095 0.00095 0.0%
YosemiteTemps MAE 1.45187 1.45187 0.0%
YosemiteTemps RMSE 2.16721 2.16721 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 93.1194 93.82 0.75%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 4.1561 4.13 -0.63%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 11.7106 11.62 -0.77%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@judussoari judussoari requested a review from karl-richter March 7, 2023 23:45
Copy link
Collaborator

@karl-richter karl-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@karl-richter karl-richter added the type:bug Something isn't working label Mar 8, 2023
@karl-richter karl-richter added this to the Release 0.5.3 milestone Mar 8, 2023
@karl-richter karl-richter merged commit d96f9f4 into main Mar 8, 2023
@karl-richter karl-richter deleted the season_params branch March 8, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants