Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typing] Add typing for user facing functions #1193

Merged
merged 24 commits into from
Mar 7, 2023

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Mar 4, 2023

🔬 Background

Close #1134

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.71298 1.71298 0.0%
YosemiteTemps RMSE_val 2.2607 2.2607 0.0%
YosemiteTemps Loss_val 0.00095 0.00095 0.0%
YosemiteTemps MAE 1.45187 1.45187 0.0%
YosemiteTemps RMSE 2.16721 2.16721 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 93.722 91.69 -2.17%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 3.80609 4.05 6.41% ⚠️
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 11.1953 11.55 3.17% ⚠️
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

Merging #1193 (1eeed2f) into main (f2ce25f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1193   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          35       35           
  Lines        4798     4799    +1     
=======================================
+ Hits         4296     4297    +1     
  Misses        502      502           
Impacted Files Coverage Δ
neuralprophet/configure.py 90.22% <100.00%> (ø)
neuralprophet/df_utils.py 94.80% <100.00%> (ø)
neuralprophet/forecaster.py 88.53% <100.00%> (+0.01%) ⬆️
neuralprophet/utils.py 79.58% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noxan noxan added this to the Release 0.5.3 milestone Mar 5, 2023
@noxan noxan requested a review from karl-richter March 5, 2023 20:17
@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label Mar 5, 2023
@noxan noxan requested review from LeonieFreisinger and removed request for karl-richter March 6, 2023 19:53
Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noxan Thanks for adding typing to the relevant functions! Great effort.

neuralprophet/forecaster.py Outdated Show resolved Hide resolved
neuralprophet/forecaster.py Show resolved Hide resolved
neuralprophet/forecaster.py Show resolved Hide resolved
@noxan noxan merged commit b456ec4 into main Mar 7, 2023
@noxan noxan deleted the add-typing-for-user-facing-functions branch March 7, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add typing to all user-facing functions
3 participants