Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pyright error raised from unbound list #1156

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Fixed pyright error raised from unbound list #1156

merged 2 commits into from
Feb 17, 2023

Conversation

judussoari
Copy link
Collaborator

@judussoari judussoari commented Feb 16, 2023

🔬 Background

Screen Shot 2023-02-16 at 12 20 50

🔮 Key changes

  • Fixed by defining a list that is empty per default, and not empty for certain conditions

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@judussoari judussoari self-assigned this Feb 16, 2023
@judussoari judussoari added this to the Release 0.5.2 milestone Feb 16, 2023
@judussoari judussoari added the type:bug Something isn't working label Feb 16, 2023
@github-actions
Copy link

github-actions bot commented Feb 16, 2023

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning time 12.1574 12.35 1.58%
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 94.0972 101.29 7.64%
AirPassengers MAE_val 15.4077 15.4077 0.0%
AirPassengers RMSE_val 19.5099 19.5099 0.0%
AirPassengers Loss_val 0.00196 0.00196 0.0%
AirPassengers MAE 9.86947 9.86947 0.0%
AirPassengers RMSE 11.7222 11.7222 0.0%
AirPassengers Loss 0.00057 0.00057 0.0%
AirPassengers time 4.12486 4.45 7.88%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #1156 (458e46f) into main (28fa4f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1156   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          36       36           
  Lines        5065     5066    +1     
=======================================
+ Hits         4568     4569    +1     
  Misses        497      497           
Impacted Files Coverage Δ
neuralprophet/forecaster.py 88.03% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@judussoari judussoari added the status: needs review PR needs to be reviewed by Reviewer(s) label Feb 16, 2023
@ourownstory ourownstory merged commit f920fb5 into main Feb 17, 2023
@ourownstory ourownstory deleted the pyright_err branch February 17, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants