Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable own NN configuration for lagged regressors #1154

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

judussoari
Copy link
Collaborator

🔬 Background

Fixes #1147
Currently, when adding lagged regressors to the model, they follow the same configuration for num_hidden_layers and d_hidden as the AR-net specified for autoregression. We would like to change that, adding an individual configuration in m.add_lagged_regressor()

🔮 Key changes

m.add_lagged_regressor() accepts new input arguments: num_hidden_layers and d_hidden.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning time 11.3559 11.73 3.29% ⚠️
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 89.7332 92.24 2.79%
AirPassengers MAE_val 15.4077 15.4077 0.0%
AirPassengers RMSE_val 19.5099 19.5099 0.0%
AirPassengers Loss_val 0.00196 0.00196 0.0%
AirPassengers MAE 9.86947 9.86947 0.0%
AirPassengers RMSE 11.7222 11.7222 0.0%
AirPassengers Loss 0.00057 0.00057 0.0%
AirPassengers time 4.08477 4.09 0.13%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #1154 (3ec1889) into main (05198ba) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1154      +/-   ##
==========================================
+ Coverage   90.17%   90.18%   +0.01%     
==========================================
  Files          36       36              
  Lines        5059     5065       +6     
==========================================
+ Hits         4562     4568       +6     
  Misses        497      497              
Impacted Files Coverage Δ
neuralprophet/configure.py 90.22% <100.00%> (+0.07%) ⬆️
neuralprophet/forecaster.py 88.02% <100.00%> (+0.05%) ⬆️
neuralprophet/time_net.py 90.68% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@judussoari judussoari added this to the Release 0.5.2 milestone Feb 9, 2023
Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @judussoari!
Looks good!

@ourownstory ourownstory merged commit 28fa4f2 into main Feb 16, 2023
@ourownstory ourownstory deleted the indiv_covarnet_config branch February 16, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow own Neural network configuration for lagged regressors
3 participants