Typing improvements

[noxan]

🔬 Background

• We have some invalid and missing type annotations

🔮 Key changes

• Reduce the number of invalid type annotations
• Add more of the missing type annotations

📋 Review Checklist

• I have performed a self-review of my own code.
• I have commented my code, added docstrings and data types to function definitions.
• I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

[codecov-commenter]

Codecov Report

Merging #1121 (97d5f30) into main (81cbbfc) will increase coverage by 0.00%.
The diff coverage is 85.71%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files          21       21           
  Lines        4845     4856   +11     
=======================================
+ Hits         4378     4388   +10     
- Misses        467      468    +1     

Impacted Files	Coverage Δ
neuralprophet/time_net.py	90.78% <ø> (ø)
neuralprophet/utils.py	81.26% <0.00%> (ø)
neuralprophet/forecaster.py	87.90% <82.14%> (-0.02%)	⬇️
neuralprophet/df_utils.py	94.69% <100.00%> (+0.01%)	⬆️
neuralprophet/hdays.py	99.73% <100.00%> (+<0.01%)	⬆️
neuralprophet/logger.py	97.43% <100.00%> (+0.06%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[karl-richter]

Looks good to me!

[github-actions]

Model Benchmark

Benchmark	Metric	main	current	diff
PeytonManning	MAE_val	0.64636	0.64636	0.0%	✅
PeytonManning	RMSE_val	0.79276	0.79276	0.0%	✅
PeytonManning	Loss_val	0.01494	0.01494	0.0%	✅
PeytonManning	MAE	0.42701	0.42701	0.0%	✅
PeytonManning	RMSE	0.57032	0.57032	0.0%	✅
PeytonManning	Loss	0.00635	0.00635	0.0%	✅
PeytonManning	time	14.0368	12.12	-13.66%	🎉
YosemiteTemps	MAE_val	1.72948	1.72949	0.0%	✅
YosemiteTemps	RMSE_val	2.27386	2.27386	0.0%	✅
YosemiteTemps	Loss_val	0.00096	0.00096	0.0%	✅
YosemiteTemps	MAE	1.45189	1.45189	0.0%	✅
YosemiteTemps	RMSE	2.16631	2.16631	0.0%	✅
YosemiteTemps	Loss	0.00066	0.00066	0.0%	✅
YosemiteTemps	time	116.591	99.41	-14.74%	🎉
AirPassengers	MAE_val	15.2698	15.2698	0.0%	✅
AirPassengers	RMSE_val	19.4209	19.4209	0.0%	✅
AirPassengers	Loss_val	0.00195	0.00195	0.0%	✅
AirPassengers	MAE	9.82902	9.82902	0.0%	✅
AirPassengers	RMSE	11.7005	11.7005	0.0%	✅
AirPassengers	Loss	0.00056	0.00056	0.0%	✅
AirPassengers	time	5.08608	4.32	-15.06%	🎉

Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers