Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipython version for plotly-resampler #1119

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Conversation

LeonieFreisinger
Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger commented Jan 17, 2023

🔬 Background

  • Plotly-resampler failes to resample the data in figure correctly. Instead of adapting the resolution with the zoom, it stayed static. That means it reduced data resolution when zooming in.

🔮 Key changes

  • The dynamic resampling failes due to the plotly and widgetsnbextension version. The plotly version must be >=5.12.0 and widgetsnbextension version >=4.0.5.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • No pytests needed

Please make sure to follow our best practices in the Contributing guidelines.

@LeonieFreisinger LeonieFreisinger added type:bug Something isn't working plotting labels Jan 17, 2023
@LeonieFreisinger LeonieFreisinger self-assigned this Jan 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1119 (ab44836) into main (479a883) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1119   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files          21       21           
  Lines        4845     4845           
=======================================
  Hits         4378     4378           
  Misses        467      467           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LeonieFreisinger
Copy link
Collaborator Author

@karl-richter would be amazing to have your support on reviewing. I sorted the requirements/base.txt in alphabetic order, don´t be confused of the high number of changes in that file. Mainly, I only edited the version of plotly and widgetsnbextension .
P.S.: I had to re-run the "tests / build (windows-latest, 3.10)" and "tests / build (windows-latest, 3.7)", because they failed the first time. Is this still a common issue?

@karl-richter karl-richter added this to the Release 0.5.2 milestone Jan 17, 2023
@karl-richter karl-richter merged commit 8bc5f62 into main Jan 17, 2023
@karl-richter karl-richter deleted the fix_ipython_version branch January 17, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants