Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate plotly resampler for static image export #1114

Merged
merged 10 commits into from
Jan 20, 2023

Conversation

karl-richter
Copy link
Collaborator

@karl-richter karl-richter commented Jan 13, 2023

🔬 Background

  • The performance tests started to fail at some point, with the figure export being the cause
  • Since neigher plotly nor the image export plugin kaleido have been updated recently, we traced this issue down to the resampler, which seems to be not compatbile with kaleido.

🔮 Key changes

  • Deactivated the resampler for the pytest where a static figure is exported

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #1114 (e06dd45) into main (1b44634) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1114   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files          21       21           
  Lines        4845     4845           
=======================================
  Hits         4378     4378           
  Misses        467      467           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@karl-richter karl-richter self-assigned this Jan 13, 2023
@karl-richter karl-richter changed the title Use orca for plotly image export Deactivate plotly resampler for static image export Jan 20, 2023
@karl-richter karl-richter added type:bug Something isn't working status: needs review PR needs to be reviewed by Reviewer(s) labels Jan 20, 2023
@github-actions
Copy link

github-actions bot commented Jan 20, 2023

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning time 16.0868 13.11 -18.5% 🎉
YosemiteTemps MAE_val 1.72948 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 130.628 111.96 -14.29% 🎉
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 5.82028 5.06 -13.06% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@karl-richter karl-richter marked this pull request as ready for review January 20, 2023 19:41
@LeonieFreisinger LeonieFreisinger self-requested a review January 20, 2023 19:56
Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passt

@karl-richter karl-richter merged commit 81cbbfc into main Jan 20, 2023
@karl-richter karl-richter deleted the fix/metrics_image_export branch January 20, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants