Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-fix] Enable test_plot_conformal_prediction with auto-regression on plot_latest_forecast #1096

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

judussoari
Copy link
Collaborator

🔬 Background

Fixes #1093

plot_latest_forecast() throws an Error because with conformal prediction, a new column name yhat1 +qhat is inserted in the forecast dataframe, which we have not dealt with before.

🔮 Key changes

Ignore those new column names for now

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@judussoari judussoari added this to the Release 0.5.2 milestone Jan 5, 2023
@judussoari judussoari requested a review from Kevin-Chen0 January 5, 2023 03:17
@judussoari judussoari self-assigned this Jan 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1096 (d3e8211) into main (b91c3fe) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1096   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files          21       21           
  Lines        4796     4796           
=======================================
  Hits         4323     4323           
  Misses        473      473           
Impacted Files Coverage Δ
neuralprophet/utils.py 81.26% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Kevin-Chen0
Copy link
Collaborator

Can you also uncomment the auto-regression part for the test_plot_conformal_prediction to ensure that this fix work? Link.

@judussoari judussoari added the status: needs review PR needs to be reviewed by Reviewer(s) label Jan 7, 2023
Copy link
Collaborator

@Kevin-Chen0 Kevin-Chen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kevin-Chen0 Kevin-Chen0 merged commit 32c2990 into main Jan 8, 2023
@Kevin-Chen0 Kevin-Chen0 deleted the plot_conformal_prediction branch January 8, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] test_plot_conformal_prediction fails with auto-regression enabled on plot_latest_forecast
3 participants