-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Convert timezones to UTC by default #1085
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 36 36
Lines 5066 5066
=======================================
Hits 4569 4569
Misses 497 497
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing with the energy dataset I receive the following issue:
AttributeError Traceback (most recent call last)
/var/folders/h5/r0lsf_xx0dgf0y4_7tyr6zx80000gn/T/ipykernel_55050/2978023471.py in <module>
4 )
5
----> 6 metrics = m.fit(df)
7
8 forecast = m.predict(df)
neural_prophet/neuralprophet/forecaster.py in fit(self, df, freq, validation_df, epochs, batch_size, learning_rate, early_stopping, minimal, metrics, progress, checkpointing, continue_training, num_workers)
...
504 return PeriodProperties(data, orig)
505
--> 506 raise AttributeError("Can only use .dt accessor with datetimelike values")
AttributeError: Can only use .dt accessor with datetimelike values
I had a brief look into it, seems https://stackoverflow.com/questions/69020835/attributeerror-can-only-use-dt-accessor-with-datetimelike-values-but-cells-con might be helpful and https://pandas.pydata.org/docs/reference/api/pandas.Series.tz_localize.html |
Would also be great to have the new code in place where the old code was, so that all checks and transformations on the |
@christymctse What's the status on this? |
Will be working on this next week |
@noxan @ourownstory, sorry about get back late |
@noxan Can you please give this another review to check whether it is ready for merge? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @christymctse for the adjustments, it works for me now - good job 👍
Model Benchmark
|
🔬 Background
🔮 Key changes
📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.