-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove default settings (None for calibration df and 0.1 for alpha) #1079
Merged
Kevin-Chen0
merged 3 commits into
ourownstory:main
from
christymctse:remove_default_setting
Dec 21, 2022
Merged
remove default settings (None for calibration df and 0.1 for alpha) #1079
Kevin-Chen0
merged 3 commits into
ourownstory:main
from
christymctse:remove_default_setting
Dec 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Kevin-Chen0
added
the
status: needs review
PR needs to be reviewed by Reviewer(s)
label
Dec 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #1079 +/- ##
=======================================
Coverage 89.98% 89.98%
=======================================
Files 21 21
Lines 4784 4784
=======================================
Hits 4305 4305
Misses 479 479
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Kevin-Chen0
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Model Benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔬 Background
Make calibration dataset and alpha mandatory when the conformal predict function is being called
🔮 Key changes
📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.