Uncertainty: Conformal Prediction V1.1 - add Conformal class to conformal_prediction.py and rename file to conformal.py #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd added plot_interval_width_per_timestep() method for multiple timesteps.
Kevin-Chen0
added
uncertainty
status: needs update
Model Benchmark
Model training plotsModel TrainingPeytonManningYosemiteTempsAirPassengers |
Codecov Report
@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
+ Coverage 90.12% 90.13% +0.01%
==========================================
Files 21 21
Lines 4788 4796 +8
==========================================
+ Hits 4315 4323 +8
Misses 473 473
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…nd _get_q_hat() methods.
Kevin-Chen0
added
status: needs review
noxan
approved these changes
Jan 2, 2023
|
|
||
| alpha: float | ||
| method: str | ||
| quantiles: list = None |
There was a problem hiding this comment.
Suggested change
| quantiles: list = None | |
| quantiles: Optional[list] = None |
There was a problem hiding this comment.
If None, NeuralProphet will automatically set it to [] behind-the-scene. Then, if 0.5 doesn't exist in the input quantiles list, then NP will automatically add it to the front of the list. Therefore, default None will become [0.5].
neuralprophet/conformal.py
Outdated
Comment on lines
1
to
3
| # import logging | ||
| # from typing import Callable, List, Optional, Type, Union | ||
|
|
There was a problem hiding this comment.
Suggested change
| # import logging | |
| # from typing import Callable, List, Optional, Type, Union |
Remove unused imports
There was a problem hiding this comment.
Suggested change
| # import logging | |
| # from typing import Callable, List, Optional, Type, Union | |
| from typing import Optional | |
Or import Optional for later usage
Co-authored-by: Richard Stromer <[email protected]>
Co-authored-by: Richard Stromer <[email protected]>
Kevin-Chen0
added
status: ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔬 Background
Conformalclass task found in Issue Conformal Prediction V1.1 tasks #1017.🔮 Key changes
Conformalclass toconformal_prediction.py, rename the file toconformal.py, and refactor the file.📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.