Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary if statement in predict_season_from_dates #1049

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

judussoari
Copy link
Collaborator

🔬 Background

If statement is never called, because predict_season_from_dates will never be called when df_name is a list
If this is the case, m.predict_seasonal_components() will be called (quick=False in plot_model_parameters_x.py)

🔮 Key changes

Deleted unnecessary code

*If statement is never called, because predict_season_from_dates will never be called when df_name is a list

*If this is the case, m.predict_seasonal_components() will be called (quick=False in plot_model_parameters_x.py
@judussoari judussoari added this to the Release 0.5.0 milestone Dec 7, 2022
@judussoari judussoari self-assigned this Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

9ead864

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 6.86499 7.04 2.55%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning time 18.5446 19.01 2.51%
YosemiteTemps MAE_val 1.72948 1.72948 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 151.353 150.96 -0.26%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

Codecov Report

Merging #1049 (1514276) into main (a450326) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
- Coverage   90.32%   90.31%   -0.01%     
==========================================
  Files          21       21              
  Lines        4764     4762       -2     
==========================================
- Hits         4303     4301       -2     
  Misses        461      461              
Impacted Files Coverage Δ
neuralprophet/plot_utils.py 89.82% <ø> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@judussoari judussoari added the status: needs review PR needs to be reviewed by Reviewer(s) label Dec 7, 2022
Copy link
Collaborator

@alfonsogarciadecorral alfonsogarciadecorral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@judussoari judussoari added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Dec 7, 2022
@noxan noxan merged commit 9ead864 into main Dec 7, 2022
@noxan noxan deleted the fix-predict-season branch December 7, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants