[bugfix] enable events while predicting into known future

[judussoari]

added events config to _maybe_extend_df()
resolves the issue of having NaN values in the events df, which led to an Error. Instead, the extended version of events_df is filled with zeros now, just like in make_future_dataframe()
Fixes #1027

[codecov-commenter]

Codecov Report

Merging #1029 (0c6835a) into main (a827517) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files          21       21           
  Lines        4737     4737           
=======================================
  Hits         4276     4276           
  Misses        461      461           

Impacted Files	Coverage Δ
neuralprophet/forecaster.py	88.45% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

784a941

Model Benchmark

Benchmark	Metric	main	current	diff
AirPassengers	MAE_val	15.2698	15.2698	0.0%	✅
AirPassengers	RMSE_val	19.4209	19.4209	0.0%	✅
AirPassengers	Loss_val	0.00195	0.00195	0.0%	✅
AirPassengers	RegLoss_val	0	0	0.0%	✅
AirPassengers	epoch	89	89	0.0%	✅
AirPassengers	MAE	9.82902	9.82902	0.0%	✅
AirPassengers	RMSE	11.7005	11.7005	0.0%	✅
AirPassengers	Loss	0.00056	0.00056	0.0%	✅
AirPassengers	RegLoss	0	0	0.0%	✅
AirPassengers	time	4.97	9.21	85.31%	⚠️
PeytonManning	MAE_val	0.64636	0.64636	-0.0%	✅
PeytonManning	RMSE_val	0.79276	0.79276	-0.0%	✅
PeytonManning	Loss_val	0.01494	0.01494	-0.0%	✅
PeytonManning	RegLoss_val	0	0	0.0%	✅
PeytonManning	epoch	37	37	0.0%	✅
PeytonManning	MAE	0.42701	0.42701	0.0%	✅
PeytonManning	RMSE	0.57032	0.57032	-0.0%	✅
PeytonManning	Loss	0.00635	0.00635	0.0%	✅
PeytonManning	RegLoss	0	0	0.0%	✅
PeytonManning	time	12.47	23.71	90.14%	⚠️
YosemiteTemps	MAE_val	1.72949	1.72948	-0.0%	✅
YosemiteTemps	RMSE_val	2.27386	2.27386	-0.0%	✅
YosemiteTemps	Loss_val	0.00096	0.00096	-0.0%	✅
YosemiteTemps	RegLoss_val	0	0	0.0%	✅
YosemiteTemps	epoch	84	84	0.0%	✅
YosemiteTemps	MAE	1.45189	1.45189	-0.0%	✅
YosemiteTemps	RMSE	2.16631	2.16631	-0.0%	✅
YosemiteTemps	Loss	0.00066	0.00066	0.0%	✅
YosemiteTemps	RegLoss	0	0	0.0%	✅
YosemiteTemps	time	102.66	201.68	96.45%	⚠️

Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

[noxan]

Great catch @judussoari

We should remove the option to not pass those variables (meaning remove the default None values here to avoid such mistakes in the future).