Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update progress bar only every epoch #1003

Merged
merged 20 commits into from
Nov 30, 2022
Merged

Conversation

karl-richter
Copy link
Collaborator

@karl-richter karl-richter commented Nov 30, 2022

Currently the progress bar by Lightning is supposed to be updated every step. With this pr, the progress bar is only updated once every epoch and shows the progress across all epochs.

@karl-richter karl-richter marked this pull request as draft November 30, 2022 00:59
@karl-richter karl-richter added the status: needs review PR needs to be reviewed by Reviewer(s) label Nov 30, 2022
@karl-richter karl-richter self-assigned this Nov 30, 2022
@github-actions
Copy link

github-actions bot commented Nov 30, 2022

8e39a4a

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%
YosemiteTemps time 100.07 101.45 1.38%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
PeytonManning time 12.49 12.4 -0.72%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
AirPassengers time 4.78 4.85 1.46%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@karl-richter karl-richter marked this pull request as ready for review November 30, 2022 01:52
@noxan noxan self-requested a review November 30, 2022 02:31
Copy link
Collaborator

@noxan noxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me - functionality I tested in terms of it has a working progress bar 😅

@noxan noxan added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Nov 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #1003 (75b25bf) into main (d6e4da3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1003      +/-   ##
==========================================
+ Coverage   89.87%   89.89%   +0.02%     
==========================================
  Files          18       18              
  Lines        4642     4653      +11     
==========================================
+ Hits         4172     4183      +11     
  Misses        470      470              
Impacted Files Coverage Δ
neuralprophet/utils.py 81.41% <100.00%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@karl-richter
Copy link
Collaborator Author

@noxan Tested the progress bar also with a validation dataset and everything seems to work fine.

@karl-richter karl-richter merged commit 8e39a4a into main Nov 30, 2022
@karl-richter karl-richter deleted the feat/epoch_progress_bar branch November 30, 2022 02:58
@noxan noxan added this to the Release Candidate 0.5.0rc1 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants