AO3-6565 Feedback

otwcode · May 16, 2024 · 681db28 · 681db28
1 parent d1e518f
commit 681db28
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/app/views/admin/admin_users/index.html.erb b/app/views/admin/admin_users/index.html.erb
@@ -31,14 +31,10 @@
       </dd>
       <% if policy(User).can_view_past? %>
         <dt><%= label_tag "settings", t(".settings.label") %></dt>
-        <dd>
-          <ul>
-              <li>
-                <%= check_box_tag "search_past", "1", params[:search_past].present? %>
-                <%= label_tag "search_past", t(".settings.past") %>
-              </li>
-          </ul>
-        </dd>
+        <li>
+          <%= check_box_tag "search_past", "1", params[:search_past].present? %>
+          <%= label_tag "search_past", t(".settings.past") %>
+        </li>
       <% end %>
     </dl>
     <p class="submit"><%= submit_tag ts("Find") %></p>

diff --git a/app/views/admin/admin_users/show.html.erb b/app/views/admin/admin_users/show.html.erb
@@ -40,18 +40,14 @@
         <% if past_logins.present? %>
           <dt><%= t(".info.past_logins", count: past_logins.size) %></dt>
           <dd>
-            <ul>
-              <li><%= past_logins.join(", ") %></li>
-            </ul>
+            <%= past_logins.to_sentence %>
           </dd>
         <% end %>
         <% past_emails = @user.historic_values("email") %>
         <% if past_emails.present? %>
           <dt><%= t(".info.past_emails", count: past_emails.size) %></dt>
           <dd>
-            <ul>
-              <li><%= past_emails.join(", ") %></li>
-            </ul>
+            <%= past_emails.to_sentence %>
           </dd>
         <% end %>
       <% end %>