AO3-6868 Change short limit from 5 to 4

otwcode · Dec 28, 2024 · 35eb306 · 35eb306
1 parent e25ad32
commit 35eb306
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/models/language.rb b/app/models/language.rb
@@ -1,6 +1,6 @@
 class Language < ApplicationRecord
   include WorksOwner
-  validates :short, presence: true, uniqueness: true, length: { maximum: 5 }
+  validates :short, presence: true, uniqueness: true, length: { maximum: 4 }
   validates :name, presence: true, uniqueness: true
 
   has_many :works

diff --git a/spec/models/language_spec.rb b/spec/models/language_spec.rb
@@ -13,17 +13,17 @@
 
   describe "validations" do
     context "for :short" do
-      it "is valid with a value 5 characters or fewer" do
+      it "is valid with a value 4 characters or fewer" do
         korean = Language.new(name: "Korean", short: "ko")
 
         expect(korean).to be_valid
       end
 
-      it "is invalid if longer than 5 characters" do
+      it "is invalid if longer than 4 characters" do
         korean = Language.new(name: "Korean", short: "korean")
 
         expect(korean).not_to be_valid
-        expect(korean.errors[:short]).to include("is too long (maximum is 5 characters)")
+        expect(korean.errors[:short]).to include("is too long (maximum is 4 characters)")
       end
     end