Generic LR cost decomposition #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcocuturi
reviewed
Jul 6, 2022
michalk8
force-pushed
the
feature/generic-lr-cost-factorization
branch
from
86b9643 to
fe7df9a
Compare
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 80.99% 82.17% +1.18%
==========================================
Files 41 41
Lines 3630 3708 +78
Branches 423 431 +8
==========================================
+ Hits 2940 3047 +107
+ Misses 568 532 -36
- Partials 122 129 +7
|
marcocuturi
approved these changes
Jul 11, 2022
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Closed
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* Initial implementation of generic LR cost decomp
* Add subset method
* Annotate array sizes, use multi_dot
* [ci skip] Make `to_LRCGeometry` in LR geom no-op
* Fix ``to_LRCGeometry`` when online, update docs
* Add factorization tests
* Add test for subsetting
* Polish documentation, add bibtex
* Fix unnecessary indents
* Disable `pytest-xdist` for all tests on CI
* Update GW to include generic LR cost decomp
* Fix LR cost conversion check in GW, add test
* Fix `{GW,}LR` tutorial, use_danskin=False in LROut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
sqeuclpoint cloudsottimport inGWLRSinkhorn.ipynbuse_danskin=FalseinLROutput.compute_reg_ot_cost(same as inLRSinkhornState); fixesLRSinkhorn.ipynb